Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade commander from 5.1.0 to 10.0.1 #8557

Merged
merged 4 commits into from
May 22, 2023

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented May 22, 2023

Pull Request

Issue

Closes: #8547

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.68 🎉

Comparison is base (4c1093e) 93.66% compared to head (5ad3b44) 94.35%.

❗ Current head 5ad3b44 differs from pull request most recent head 94b8e64. Consider uploading reports for the commit 94b8e64 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8557      +/-   ##
==========================================
+ Coverage   93.66%   94.35%   +0.68%     
==========================================
  Files         183      183              
  Lines       14575    14575              
==========================================
+ Hits        13652    13752     +100     
+ Misses        923      823     -100     
Impacted Files Coverage Δ
src/cli/utils/commander.js 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dblythy dblythy requested a review from a team May 22, 2023 04:45
@mtrezza mtrezza merged commit a005874 into parse-community:alpha May 22, 2023
22 of 24 checks passed
@dblythy dblythy deleted the upgrade-commander branch May 23, 2023 05:30
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.13

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 25, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants