Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch from Yoga v2 to Apollo V4 merge #8893

Conversation

onurhanife
Copy link
Contributor

Pull Request

Issue

Closes: #8728

Approach

#8727 cloned, merged into alpha and conflicts resolved

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: switch from Yoga v2 to Apollo V4 merge feat: Switch from Yoga v2 to Apollo V4 merge Jan 17, 2024
Copy link

Thanks for opening this pull request!

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 94.22%. Comparing base (f5d6fc9) to head (e8163ef).

❗ Current head e8163ef differs from pull request most recent head 7d453a9. Consider uploading reports for the commit 7d453a9 to get more accurate results

Files Patch % Lines
src/GraphQL/loaders/filesMutations.js 88.88% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8893      +/-   ##
==========================================
+ Coverage   94.20%   94.22%   +0.02%     
==========================================
  Files         186      186              
  Lines       14797    14842      +45     
==========================================
+ Hits        13939    13985      +46     
+ Misses        858      857       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you again resolve the conflicts please?

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains unrelated code style changes, please revert these. Are they applied automatically by your IDE, or is that our pre-commit hook?

@mtrezza mtrezza closed this Feb 26, 2024
@onurhanife
Copy link
Contributor Author

@mtrezza Did you also solved the issue or was there a mistake? Seems like you refers to different PR

@mtrezza mtrezza reopened this Feb 26, 2024
@mtrezza
Copy link
Member

mtrezza commented Feb 26, 2024

Apologies, I mixed up the browser tabs. This PR is still open.

@onurhanife
Copy link
Contributor Author

@mtrezza Hi, the code style changes are coming from parse-server's pre-commit hook.

@mtrezza
Copy link
Member

mtrezza commented Feb 27, 2024

Could you just disable the hook in your local repo please, to make this easier.

@onurhanife
Copy link
Contributor Author

Closing via #8959

@onurhanife onurhanife closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from Yoga v2 to Apollo V4
3 participants