Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests against the filesystem? #7

Closed
paulirish opened this issue Feb 26, 2015 · 5 comments
Closed

tests against the filesystem? #7

paulirish opened this issue Feb 26, 2015 · 5 comments

Comments

@paulirish
Copy link
Contributor

Can you drop these in as filenames and verify they are never rejected?
@parshap
Copy link
Owner

parshap commented Feb 26, 2015

Do you mean tests that call fs.writeFile and make sure there is no error? That sounds like a good idea.

@paulirish
Copy link
Contributor Author

Yup!
On Feb 26, 2015 1:30 PM, "Parsha Pourkhomami" notifications@github.com
wrote:

Do you mean tests that call fs.writeFile and make sure there is no error?
That sounds like a good idea.

—
Reply to this email directly or view it on GitHub
#7 (comment)
.

@parshap
Copy link
Owner

parshap commented Feb 26, 2015

Ok. I will try to get this in or will gladly accept a patch.

@parshap
Copy link
Owner

parshap commented Feb 27, 2015

Added in 2bc7917 and published in 1.1.4. Thanks for the idea!

@parshap
Copy link
Owner

parshap commented Feb 27, 2015

If you have any more test cases in mind other than the file names that are currently there, I'd be happy to add them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulirish @parshap