Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a clean implementation for NOT_A_VALUE #280

Closed
jvdb opened this issue Feb 5, 2019 · 1 comment
Closed

Create a clean implementation for NOT_A_VALUE #280

jvdb opened this issue Feb 5, 2019 · 1 comment
Assignees
@jvdb
Labels
enhancement
Milestone
8.0.0

Comments

@jvdb
Copy link
Contributor

jvdb commented Feb 5, 2019 •
edited
Loading

The work on #279 will lead to a rather simple approach to NOT_A_VALUE that is a little error-prone (basically, because it is possible for a user of the library to create a valid Value object that is the same as the NOT_A_VALUE-constant).

A clean approach will be to split Value into a Value interface and a ValueImpl (or BaseValue, CoreValue, ...) class. A NotAValue class can then be created with only a private constructor that is called when instantiating the constant. The ValueImpl's constructor(s) can then forbid constructing a zero-sized Value.
@jvdb jvdb self-assigned this Feb 5, 2019
@jvdb jvdb pinned this issue Feb 5, 2019
This was referenced Feb 5, 2019
Closed
Merged
jvdb added a commit that referenced this issue Feb 7, 2019
@jvdb
#280: Changed Value into an interface, extracted functionality into C…
f3db1f8 
…oreValue.
jvdb added a commit that referenced this issue Feb 7, 2019
@jvdb
#280: Moved NOT_A_VALUE from CoreValue back to Value.
9732725
jvdb added a commit that referenced this issue Feb 7, 2019
@jvdb
#280: Created NotAValue class.
34ccd75
jvdb added a commit that referenced this issue Feb 8, 2019
@jvdb
#280: Replaced reference checks on NOT_A_VALUE with calls to equals().
33d8584
jvdb added a commit that referenced this issue Feb 10, 2019
@jvdb
#280: Added and adapted unit tests for NotAValue.
5b066d4
jvdb added a commit that referenced this issue Feb 10, 2019
@jvdb
#280: Added missing license header.
0755624
jvdb added a commit that referenced this issue Feb 11, 2019
@jvdb
#280: Made the NotAValue class final to ensure uniqueness of NOT_A_VA…
87e0260 
…LUE.
@jvdb jvdb mentioned this issue Feb 13, 2019
Merged
jvdb added a commit that referenced this issue Feb 16, 2019
@jvdb
#280: Fixed stack trace issue with exceptions thrown from NotAValue b…
b712149 
…ased on @rdvdijk and @ccreeten comments.
jvdb added a commit that referenced this issue Feb 16, 2019
@jvdb
#280: Renamed and fixed spacing between interface/abstract methods. B…
6480c62 
…ased on comments of @rdvdijk and @ccreeten.
jvdb added a commit that referenced this issue Feb 17, 2019
@jvdb
Merge pull request #281 from parsingdata/from-list-of-optionals-to-op…
59d573a 
…tional-list

Change return value of ValueExpression.eval(...) to ImmutableList<Value> (#279), extract Value interface and create dedicated NotAValue class and instance (#280), implement SingleValueExpression to let the compiler help more when writing incorrect Metal tokens/expressions (#70).
@jvdb
Copy link
Contributor Author

jvdb commented Feb 17, 2019

#282 is merged, so issue closed (no autoclose it seems because it was merged through another branch/PR first...)

@jvdb jvdb closed this as completed Feb 17, 2019
@jvdb jvdb unpinned this issue Feb 17, 2019
@jvdb jvdb added this to the 8.0.0 milestone Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvdb jvdb

Labels
enhancement
Milestone
8.0.0
Development

No branches or pull requests
1 participant
@jvdb