Convert Value to interface, extract functionality to CoreValue and create a NotAValue class #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## from-list-of-optionals-to-optional-list #282 +/- ##
========================================================================
Coverage 100% 100%
- Complexity 1029 1047 +18
========================================================================
Files 92 94 +2
Lines 1393 1399 +6
Branches 154 150 -4
========================================================================
+ Hits 1393 1399 +6
Continue to review full report at Codecov.
|
…f Def to SingleValueExpression, along with all dependencies.
…h all dependencies.
…and Self to SingleValueExpression.
…ons to SingleValueExpression.
2 tasks
rdvdijk
approved these changes
Feb 13, 2019
core/src/main/java/io/parsingdata/metal/expression/value/NotAValue.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/parsingdata/metal/expression/value/Value.java
Outdated
Show resolved
Hide resolved
mvanaken
approved these changes
Feb 13, 2019
Add SingleValueExpression to type ValueExpressions that always return a single value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges to the branch of #281. So please review that first.
The conversion in #281 was complicated by the need for
NOT_A_VALUEto be a direct instance ofValue, which was a class and not an interface. This is fixed in this PR.Valueis now an interface, andNOT_A_VALUEis an instance ofNotAValue, which implementsValuebut which itself cannot be instantiated (private constructor), guaranteeing the uniqueness ofNOT_A_VALUE.This PR resolves #280.