Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Result generation after quiz attempt #4

Merged
merged 8 commits into from
May 21, 2022
Merged

[Feat]: Result generation after quiz attempt #4

merged 8 commits into from
May 21, 2022

Conversation

parthpandyappp
Copy link
Owner

@parthpandyappp parthpandyappp commented May 20, 2022 •
edited
Loading

  • Score evaluation
  • Storing the latest scores in the db (To be used in next PR to list down the latest scores of the user)
  • Displaying correct options as well as the one chosen by user.

note:

  • Deploy preview below is usable as I've added that domain to the list of auth-domain in firebase
  • All the logs for error handling will be replaced by toasts in future commits

@netlify
Copy link

netlify bot commented May 20, 2022 •
edited
Loading

✅ Deploy Preview for jest-quizionnaire ready!

Name Link
🔨 Latest commit 7fcd12b
🔍 Latest deploy log https://app.netlify.com/sites/jest-quizionnaire/deploys/6287819586357000087b7ea2
😎 Deploy Preview https://deploy-preview-4--jest-quizionnaire.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sharmaryan
Sharmaryan approved these changes May 20, 2022
View reviewed changes
Copy link

@Sharmaryan Sharmaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • UI is simple and looking good
  • change your app name, it is showing react app
  • code is clean

Logan1x
Logan1x reviewed May 21, 2022
View reviewed changes
src/backend/index.js
import { getFirestore } from "firebase/firestore";

const firebaseConfig = {
apiKey: process.env.REACT_APP_apiKey,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Env Variable has been used, nice feat.

Logan1x
Logan1x approved these changes May 21, 2022
View reviewed changes
Copy link

@Logan1x Logan1x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Good use of Env to hide variables.
  • use firebase for auth, nice.
  • Meta tags are good for seo

@parthpandyappp parthpandyappp merged commit 7fcd12b into dev May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Logan1x Logan1x Logan1x approved these changes

@Sharmaryan Sharmaryan Sharmaryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthpandyappp @Logan1x @Sharmaryan