Return IMEI with ICCID in one request #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2024
|
We discussed in standup that Keerthy would rework this to add the IMEI field to the same request as ICCID since they are likely to always be requested together |
|
I made the change here. I will make the change in the device-os in a bit. |
monkbroc
approved these changes
Jan 24, 2024
|
@monkbroc In that case, I will merge this in. Thank you for taking a look. |
keeramis
force-pushed
the
feature/imei-macaddr
branch
from
6a4b0ec
to
1a68fdc
Compare
keeramis
force-pushed
the
feature/imei-macaddr
branch
from
1a68fdc
to
07358b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds entires for cell radio imei
References
Particle-USB : particle-iot/particle-usb#98
Particle-CLI : particle-iot/particle-cli#713
Device-OS : particle-iot/device-os#2730