Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ICCID control request to Include IMEI and ICCID #2730

Merged
merged 1 commit into from Feb 7, 2024

Conversation

keeramis
Copy link
Contributor

@keeramis keeramis commented Jan 22, 2024

Description

This branch / PR adds IMEI to the response of the ICCID control request

Steps to Test

  • Checkout this branch
  • Flash a device (either cellular or wifi) with a tinker app
  • Use particle-cli branch with the testing instructions : Feature/replace serial cmds particle-cli#713
  • From particle-cli repo, run npm start -- serial mac on wifi device, or npm start -- serial identify from cellular device

Example App

void setup() {
  /* A minimal example app is super helpful 
   * for testing new features and fixes. 
   * A link to a Docs PR is even better!
   */
}

void loop() {

}

References

Particle-CLI : particle-iot/particle-cli#713
Particle-USB : particle-iot/device-os-protobuf#26
Device-os-protobuf: particle-iot/device-os-protobuf#26


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@@ -357,6 +357,10 @@ void SystemControl::processRequest(ctrl_request* req, ControlRequestChannel* /*
setResult(req, ctrl::wifi::scanNetworks(req));
break;
}
case CTRL_REQUEST_WIFI_MAC_ADDRESS: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This request should not really be necessary. MAC addresses are available since introduction of CTRL_REQUEST_NETWORK_GET_INTERFACE_LIST and CTRL_REQUEST_NETWORK_GET_INTERFACE: https://github.com/particle-iot/device-os-protobuf/blob/main/control/network.proto#L94

Copy link
Member

@avtolstoy avtolstoy Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a new request to get a 'base MAC' and size of the allocation per device, but it's not going to be wifi-specific, it's more of a device identifier-like data similar to serial/device id/mobile secret etc.

For Gen 4 devices the size of the allocation is 4 for example:
0 - WiFi STA
1 - WiFi AP
2 - BLE
3 - Ethernet

WiFi-specific MAC should be picked from interface data and should be available since Device OS 3.x.

@keeramis keeramis force-pushed the feature/add-ctrl-req-imei-macaddr branch 2 times, most recently from c6199bb to 30e1ec0 Compare January 29, 2024 14:57
@keeramis keeramis marked this pull request as draft January 29, 2024 15:06
@keeramis keeramis force-pushed the feature/add-ctrl-req-imei-macaddr branch 2 times, most recently from c04583d to 74cb5ff Compare January 29, 2024 19:48
@keeramis keeramis changed the title Feature/add ctrl req imei macaddr Enhance ICCID Control Request to Include IMEI and ICCID Jan 29, 2024
@keeramis keeramis changed the title Enhance ICCID Control Request to Include IMEI and ICCID Enhance ICCID control request to Include IMEI and ICCID Jan 29, 2024
@keeramis keeramis force-pushed the feature/add-ctrl-req-imei-macaddr branch from 9e4dd2d to bf929ae Compare February 6, 2024 18:56
@keeramis keeramis marked this pull request as ready for review February 6, 2024 19:58
@keeramis
Copy link
Contributor Author

keeramis commented Feb 6, 2024

Hi @avtolstoy This PR is ready to be merged. Pinging you here in case you would like to take a look before I merge it in. TY! Hope this can make it to 5.8.0

@keeramis keeramis added this to the 5.8.0 milestone Feb 6, 2024
@keeramis keeramis merged commit 1b02456 into develop Feb 7, 2024
13 checks passed
@keeramis keeramis deleted the feature/add-ctrl-req-imei-macaddr branch February 7, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants