Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dynamically configurable logging by default #1213

Merged
merged 1 commit into from Dec 19, 2016

Conversation

@sergeuz
Copy link
Member

commented Dec 19, 2016

This PR makes dynamically configurable logging enabled only if application calls System.enableFeature(FEATURE_CONFIGURABLE_LOGGING) explicitly. This allows to significantly reduce size of application binary for applications that don't use logging.

No documentation is provided, since we currently don't have support for dynamically configurable logging in our developer tools, such as the CLI.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled

N/A updates to exiting PR's submitted for 0.6.1-rc.1 (CHANGELOG updated)

  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)

@sergeuz sergeuz added this to the 0.6.1 milestone Dec 19, 2016

@technobly technobly merged commit 106c5a0 into develop Dec 19, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/optional_log_config branch Dec 19, 2016

@technobly technobly removed their assignment Dec 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.