Disable dynamically configurable logging by default

user/tests/accept/features/logging/log_config_app/app.cpp

@@ -2,6 +2,9 @@
 
 SYSTEM_MODE(MANUAL)
 
+// Enable dynamically configurable logging
+STARTUP(System.enableFeature(FEATURE_CONFIGURABLE_LOGGING))
+
 bool usb_request_custom_handler(char* buf, size_t bufSize, size_t reqSize, size_t* repSize) {
     const char* msg = "Test message";
     const char* cat = "app"; // Category name

wiring/inc/spark_wiring_system.h

@@ -24,6 +24,7 @@
 #define SPARK_WIRING_SYSTEM_H
 #include "spark_wiring_ticks.h"
 #include "spark_wiring_string.h"
+#include "spark_wiring_platform.h"
 #include "spark_wiring_version.h"
 #include "system_mode.h"
 #include "system_update.h"
@@ -68,6 +69,11 @@ class SleepNetworkFlag
 const SleepNetworkFlag SLEEP_NETWORK_OFF(SystemSleepNetwork::Off);
 const SleepNetworkFlag SLEEP_NETWORK_STANDBY(SystemSleepNetwork::Standby);
 
+#if Wiring_LogConfig
+enum LoggingFeature {
+    FEATURE_CONFIGURABLE_LOGGING = 1
+};
+#endif
 
 class SystemClass {
 public:
@@ -199,6 +205,10 @@ class SystemClass {
         return HAL_Feature_Set(feature, false);
     }
 
+#if Wiring_LogConfig
+    bool enableFeature(LoggingFeature feature);
+#endif
+
     String version()
     {
         SystemVersionInfo info;

wiring/src/spark_wiring_system.cpp

@@ -4,9 +4,14 @@
 #include "rgbled.h"
 #include "spark_wiring_wifi.h"
 #include "spark_wiring_cloud.h"
+#include "spark_wiring_logging.h"
 #include "system_task.h"
+#include "system_control.h"
 #include "system_network.h"
 
+#if Wiring_LogConfig
+extern bool(*log_process_config_request_callback)(char*, size_t, size_t, size_t*, DataFormat);
+#endif
 
 SystemClass System;
 
@@ -53,3 +58,10 @@ uint32_t SystemClass::freeMemory()
     HAL_Core_Runtime_Info(&info, NULL);
     return info.freeheap;
 }
+
+#if Wiring_LogConfig
+bool SystemClass::enableFeature(LoggingFeature) {
+    log_process_config_request_callback = spark::logProcessConfigRequest;
+    return true;
+}
+#endif

wiring/src/user.cpp

@@ -22,6 +22,7 @@
  */
 
 #include "system_user.h"
+#include "system_control.h"
 #include <stddef.h>
 #include <string.h>
 #include "spark_wiring_platform.h"
@@ -163,7 +164,10 @@ bool __backup_ram_was_valid() { return false; }
 
 #endif
 
-#include "system_control.h"
+#if Wiring_LogConfig
+// Callback invoked to process USB request for logging configuration
+bool(*log_process_config_request_callback)(char*, size_t, size_t, size_t*, DataFormat) = nullptr;
+#endif
 
 #ifdef USB_VENDOR_REQUEST_ENABLE
 
@@ -174,13 +178,16 @@ bool __attribute((weak)) usb_request_custom_handler(char* buf, size_t buf_size,
 
 bool usb_request_app_handler(USBRequest* req, void* reserved) {
     switch (req->type) {
+#if Wiring_LogConfig
     case USB_REQUEST_LOG_CONFIG: {
-        if (!spark::logProcessConfigRequest(req->data, USB_REQUEST_BUFFER_SIZE, req->request_size, &req->reply_size, (DataFormat)req->format)) {
+        if (!log_process_config_request_callback || !log_process_config_request_callback(req->data, USB_REQUEST_BUFFER_SIZE,
+                req->request_size, &req->reply_size, (DataFormat)req->format)) {
             return false;
         }
         system_set_usb_request_result(req, USB_REQUEST_RESULT_OK, nullptr);
         return true;
     }
+#endif
     case USB_REQUEST_CUSTOM: {
         if (!usb_request_custom_handler(req->data, USB_REQUEST_BUFFER_SIZE, req->request_size, &req->reply_size)) {
             return false;