Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Correctly process APPLICATION/SYSTEM DESCRIBE requests #1226
NOTE: Device currently receives incorrect DESCRIBE request with
The PR accounts for this by assuming that the server actually requests
Jan 13, 2017
@avtolstoy - I had issues with this when trying to get functions/variables because of instead of 1 coap message == 1 response, I had to listen for two responses.
This looks like it should fix things but can I expect that the entire description (system + functions + variables) will fit in the COAP message or should I start passing flags to get both?
Are we talking UDP or TCP here? Electron receives and processes separate SYSTEM/APPLICATION DESCRIBE requests; I would assume exactly to fit the CoAP message into MTU. With TCP that shouldn't be a problem at all, since TCP is stream based. Photon doesn't receive any flags and defaults to DESCRIBE_ALL. Previously it was responding with two separate messages as described in #1181. There is still a piece of code missing that strips the AES padding, but no-flags + padding should still be correctly handled now.