Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename system_error to system_error_t #1326

Merged
merged 1 commit into from May 10, 2017

Conversation

@sergeuz
Copy link
Member

commented May 10, 2017

Problem

C++11 defines std::system_error class which may cause global name conflicts with the firmware's system_error enum, especially in applications that abuse using namespace std.

Solution

Rename system_error enum to system_error_t. We never exposed system_error as part of any public API, so the fix won't affect existing applications.

Steps to Test

The firmware and unit tests should build normally.

Example App

N/A

References

Original community post: https://community.particle.io/t/compile-error-gcc-arm-on-linux-firmware-v-0-6-1/31157


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

Bugfix

  • [PR #1326] Renamed system_error enum to system_error_t to avoid conflicts with std::system_error class.

@sergeuz sergeuz added the bug label May 10, 2017

@sergeuz sergeuz added this to the 0.7.0 milestone May 10, 2017

@sergeuz sergeuz requested a review from technobly May 10, 2017

@technobly technobly merged commit 4b661eb into develop May 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/system_error_enum branch May 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.