Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] [photon/p1] crypto: re-enables MD5 for TLS (WPA Enterprise) #1743

Merged
merged 1 commit into from Apr 4, 2019

Conversation

@avtolstoy
Copy link
Member

commented Apr 4, 2019

Problem

MD5 got erroneously disabled for Photon and P1 during the development of 1.1.0-rc.1, which prevents WPA Enterprise authentication not working correctly.

Solution

Bring it back!

Steps to Test

Connect to WPA Enterprise AP with PEAP. Your device shouldn't crash.

Example App

N/A

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [internal] [photon/p1] crypto: re-enables MD5 for TLS (WPA Enterprise) #1743
[photon/p1] crypto: accidentally disabled MD5 on Photon and P1, which…
… caused issues with WPA Ent authorization

@avtolstoy avtolstoy added this to the 1.1.0-rc.1 milestone Apr 4, 2019

@avtolstoy avtolstoy requested a review from technobly Apr 4, 2019

@technobly technobly merged commit 8118508 into develop Apr 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@technobly technobly deleted the fix/photon-p1-wpa-ent-md5 branch Apr 4, 2019

@technobly technobly changed the title [photon/p1] crypto: re-enables MD5 for TLS (WPA Enterprise) [internal] [photon/p1] crypto: re-enables MD5 for TLS (WPA Enterprise) Apr 4, 2019

@technobly technobly added the internal label Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.