[internal] [photon/p1] crypto: re-enables MD5 for TLS (WPA Enterprise) #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… caused issues with WPA Ent authorization
technobly
approved these changes
Apr 4, 2019
technobly
added
bug
ready to merge
technobly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MD5 got erroneously disabled for Photon and P1 during the development of 1.1.0-rc.1, which prevents WPA Enterprise authentication not working correctly.
Solution
Bring it back!
Steps to Test
Connect to WPA Enterprise AP with PEAP. Your device shouldn't crash.
Example App
N/A
References
N/A
Completeness