HAL: add always_inline attribute for deprecated APIs #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YutingYou
approved these changes
Sep 24, 2020
XuGuohui
force-pushed
the
fix/always_inline_deprecated_apis/ch63831
branch
from
5e1525b
to
d46b26e
Compare
XuGuohui
added
ready to merge
avtolstoy
approved these changes
Oct 2, 2020
…se APIs are invoked in c file but not inlined by compiler.
avtolstoy
force-pushed
the
fix/always_inline_deprecated_apis/ch63831
branch
from
d46b26e
to
4344e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the deprecated APIs are invoked in c files, they might not be inlined by compiler actually, which would encounter "undefined reference xxxx" error.
Solution
Add
always_inlineattribute for the deprecated functions.References
N/A
Completeness