-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wiring] Network: introduce isOn() and isOff() APIs to enquiry the modem power state #2205
[wiring] Network: introduce isOn() and isOff() APIs to enquiry the modem power state #2205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to having these essential APIs! Would be nice to see how they can be used with the Future API and waitFor/waitUntil, perhaps in some tests? :D
804745f
to
94940f5
Compare
@technobly @avtolstoy I just revised the PR. Looking forward to your review and any comments. |
@XuGuohui We can do this in a separate PR, but let's also make sure that |
// It's tricky to detect the modem power state. | ||
// We assume that every time the device being powered up, the module is powered on. | ||
// The the power state then be tracked by the on_now() and off_now() APIs. | ||
bool powered = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we previously figured out that on boot BCM43362 is powered off, so we should be able to safely set this to false
by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's on by default: #2205 (comment)
850d796
to
07e398a
Compare
As the title describes.
Example App
Completeness