Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] generate public CF url in slack notification #2333

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

avtolstoy
Copy link
Member

Problem

$CF_BUILD_URL generated by CF contains a private URL requiring CF sign-in even though we have public build logs enabled on CF.

Solution

Patch it.

Steps to Test

Take a look at Device OS bots channel for build logs out of this branch/PR - the URL should be public and viewable without sign-in.

Example App

N/A

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy merged commit ae01e6a into develop Jun 25, 2021
@avtolstoy avtolstoy deleted the feature/cf-public-url-slack-message branch June 25, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants