Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gen3][esomx] Define E404X platform #2443

Merged
merged 9 commits into from
Jun 7, 2022

Conversation

scott-brust
Copy link
Member

Problem

E404X Hardware needs to be supported in DVOS

Solution

Add new PLATFORM_ID for esomx platform, largely based off of boron module/platform definitions

Steps to Test

Build using new platform and test with boron hardware:

make PLATFORM=esomx APP=tinker clean all

Example App

Use tinker


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

Copy link
Member

@XuGuohui XuGuohui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the following files need to be modified as well:

  1. platform/MCU/nRF52840/src/hw_config.c, line 197
  2. user/applications/tinker/application.cpp
  3. user/tests/wiring/no_fixture_long_running/network.cpp, pwm.cpp
  4. user/tests/wiring/spi_master_slave

build/platform-id.mk Outdated Show resolved Hide resolved
hal/src/boron/app_usbd_string_config.h Outdated Show resolved Hide resolved
hal/src/boron/app_usbd_string_config.h Outdated Show resolved Hide resolved
hal/src/boron/hal_platform_config.h Outdated Show resolved Hide resolved
platform/MCU/nRF52840/inc/platform_config.h Show resolved Hide resolved
@scott-brust
Copy link
Member Author

I think the following files need to be modified as well:

  1. platform/MCU/nRF52840/src/hw_config.c, line 197
  2. user/applications/tinker/application.cpp
  3. user/tests/wiring/no_fixture_long_running/network.cpp, pwm.cpp
  4. user/tests/wiring/spi_master_slave

I'm working on pinmap next and will update tinker and tests then

#define HAL_PLATFORM_FUELGAUGE_MAX17043_I2C (HAL_I2C_INTERFACE2)
#define HAL_PLATFORM_RADIO_ANTENNA_INTERNAL (0)
#define HAL_PLATFORM_RADIO_ANTENNA_EXTERNAL (1)
#define HAL_PLATFORM_FLASH_MX25L3233F (1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is using 8M flash, need to change macro #define HAL_PLATFORM_FLASH_MX25L3233F (1) to #define HAL_PLATFORM_FLASH_MX25R6435FZNIL0 (1)

hal/src/boron/pinmap_hal.c Show resolved Hide resolved
hal/src/boron/pinmap_defines.h Show resolved Hide resolved
@technobly technobly changed the title [gen3][E404X] Define E404X platform [gen3][esomx] Define E404X platform Apr 30, 2022
@XuGuohui XuGuohui force-pushed the feature/sc-101084/e404x-platform branch from 41eaf41 to eebc331 Compare June 7, 2022 09:16
@XuGuohui XuGuohui self-requested a review June 7, 2022 09:52
@XuGuohui XuGuohui merged commit 7a08b72 into develop Jun 7, 2022
@XuGuohui XuGuohui deleted the feature/sc-101084/e404x-platform branch June 7, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants