Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gen3] WiFi resolve tests need retries #2454

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

keeramis
Copy link
Contributor

@keeramis keeramis commented May 19, 2022

Problem

WiFi.resolve() tests sometimes fail when run with a new connection

Solution

Add retries

Steps to Test

Run wiring/no_fixture_wifi on device-os test runner and ensure tests pass.

  No fixture wifi
    argon
      systemThread=disabled
        ✓ WIFI_00_connect (26.7s)
        ✓ WIFI_01_resolve_3_levels (5.8s)
        ✓ WIFI_02_resolve_4_levels
        ✓ WIFI_03_resolve
        ✓ WIFI_04_config
        ✓ WIFI_05_scan (4.8s)
        ✓ WIFI_06_restore_connection
        ✓ WIFI_11_scan_returns_zero_result_or_error_when_wifi_is_off (6.9s)
        ✓ WIFI_12_restore_connection
        ✓ WIFI_13_wifi_class_methods_work_correctly_when_wifi_interface_is_off (2.9s)
      systemThread=enabled
        ✓ WIFI_00_connect (19.3s)
        ✓ WIFI_01_resolve_3_levels (5.8s)
        ✓ WIFI_02_resolve_4_levels (5.8s)
        ✓ WIFI_03_resolve (5.8s)
        ✓ WIFI_04_config
        ✓ WIFI_05_scan (4.8s)
        ✓ WIFI_06_restore_connection
        ✓ WIFI_11_scan_returns_zero_result_or_error_when_wifi_is_off (5.6s)
        ✓ WIFI_12_restore_connection
        ✓ WIFI_13_wifi_class_methods_work_correctly_when_wifi_interface_is_off (1.6s)

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@keeramis keeramis merged commit f6eeaba into develop May 19, 2022
@keeramis keeramis deleted the fix/wifi_resolve_tests branch May 19, 2022 14:39
@technobly technobly added this to the 4.0.0 milestone May 19, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants