Adds support for BG95-M1, BG95-MF, BG77, and EG91-NAX [sc-102979] #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeramis
requested changes
May 31, 2022
There was a problem hiding this comment.
ncp needs to be added here as well. (edited: If we are keeping platform_ncp_identifier )
https://github.com/particle-iot/device-os/blob/feature/sc-102979/hal/shared/platform_ncp.cpp#L29
tstellanova
approved these changes
May 31, 2022
tstellanova
approved these changes
May 31, 2022
keeramis
approved these changes
Jun 1, 2022
This was referenced Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for BG77, BG95-M1, BG95-MF, and EG91-NAX.
References
#2367 (supersedes this PR due to build error in CircleCI, however refer to any previous comments from that PR before merging)
#2410 (supersedes this PR, to change the branch name)
Completeness