Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix to ensure PS only mode is only applied to R510 at this time #2645

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

technobly
Copy link
Member

Problem

R410 was failing the slo/connect_time tests due to PS only mode not being saved for R410 devices.

Solution

Guard against running PS only mode code for any device other than R510 for now to preserve system cache settings for those devices, in case we decide to enable this for them in the future.

Steps to Test

Run integration tests slo/connect_time for R410 based devices.

References

#2639


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@technobly technobly added this to the 5.3.1 milestone Apr 7, 2023
@technobly technobly merged commit e1dabce into develop Apr 7, 2023
@technobly technobly deleted the fix/r410-slo-connect-time branch April 7, 2023 16:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants