Feature/sc 124023/refactor-list #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomontero
changed the base branch from
feature/logic-function
to
feature/ui-minor-changes
hugomontero
commented
Dec 14, 2023
| class LogicFunction { | ||
| constructor({ org, api = createAPI() }) { | ||
| // throw if api is not provided | ||
| this.org = org; |
There was a problem hiding this comment.
This is not the final object. I'll refine it once I complete the whole refactor.
hugomontero
changed the title
keeramis
approved these changes
Dec 14, 2023
hugomontero
changed the base branch from
feature/ui-minor-changes
to
feature/logic-function
keeramis
force-pushed
the
feature/logic-function
branch
from
5a2c936
to
de60aad
Compare
monkbroc
force-pushed
the
feature/logic-function
branch
from
07e767f
to
806b240
Compare
monkbroc
deleted the
feature/sc-124023/create-logic-function-helper-to-put-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will refactor the LogicFunction list command in order to use a LogicFunction class with static methods.
How to Test
git pull && git checkout feature/sc-124023/create-logic-function-helper-to-put-filenpm inpm run test:unitnpm start -- logic-function listoutcome
Related Issues / Discussions
Story details: https://app.shortcut.com/particle/story/124023/create-logic-function-helper-to-put-file-interaction-functions-instead-of-in-cmd-class
Completeness