-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sc 124023/refactor-list #702
Merged
hugomontero
merged 4 commits into
feature/logic-function
from
feature/sc-124023/create-logic-function-helper-to-put-file
Dec 21, 2023
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| const ParticleAPI = require('../cmd/api'); | ||
| const settings = require('../../settings'); | ||
|
|
||
| class LogicFunction { | ||
| constructor({ org, api = createAPI() }) { | ||
| // throw if api is not provided | ||
| this.org = org; | ||
| this.api = api; | ||
| this.configuration = {}; | ||
| this.source = { | ||
| type: '', | ||
| code: '' | ||
| }; | ||
| this.fileNames = { | ||
| source: '', | ||
| configuration: '' | ||
| }; | ||
| } | ||
|
|
||
| static async listFromCloud({ org, api = createAPI() } = {}) { | ||
| const response = await api.getLogicFunctionList({ org: org }); | ||
| const logicFunctions = response.logic_functions; | ||
| return logicFunctions; | ||
| } | ||
|
|
||
| static async listFromDisk({ path }) { | ||
| // TODO - implement | ||
| throw new Error(`Not implemented yet for ${path}`); | ||
| } | ||
|
|
||
| // should return an instance of LogicFunction | ||
| static async getByIdOrName({ id, name, list }) { | ||
| // TODO - implement | ||
| throw new Error(`Not implemented yet for ${id} or ${name} or ${list}`); | ||
| // throw new Error(`Not implemented yet for ${id} or ${name}`); | ||
| } | ||
|
|
||
| saveToDisk(path){ | ||
| // TODO - implement | ||
| throw new Error(`Not implemented yet for ${path}`); | ||
| } | ||
| } | ||
|
|
||
| function createAPI() { | ||
| return new ParticleAPI(settings.apiUrl, { | ||
| accessToken: settings.access_token | ||
| }); | ||
| } | ||
|
|
||
| module.exports = LogicFunction; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| const { expect } = require('chai'); | ||
| const LogicFunction = require('./logic-function'); | ||
| const nock = require('nock'); | ||
|
|
||
|
|
||
| describe('LogicFunction', () => { | ||
| describe('list', () => { | ||
| it('returns an empty array if there are no logic functions', async () => { | ||
| nock('https://api.particle.io/v1/', ) | ||
| .intercept('/logic/functions', 'GET') | ||
| .reply(200, { logic_functions : [] } ); | ||
| const logicFunctions = await LogicFunction.listFromCloud(); | ||
| expect(logicFunctions).to.have.lengthOf(0); | ||
| }); | ||
| it('returns a list of logic functions', async () => { | ||
| nock('https://api.particle.io/v1/', ) | ||
| .intercept('/logic/functions', 'GET') | ||
| .reply(200, { logic_functions : [{ name: 'my-logic-function' }] } ); | ||
|
|
||
| const logicFunctions = await LogicFunction.listFromCloud(); | ||
| expect(logicFunctions).to.have.lengthOf(1); | ||
| }); | ||
|
|
||
| it('returns a list of logic functions from an specific org', async () => { | ||
| nock('https://api.particle.io/v1/orgs/', ) | ||
| .intercept('/my-org/logic/functions', 'GET') | ||
| .reply(200, { logic_functions : [{ name: 'my-logic-function' }] } ); | ||
| const logicFunctions = await LogicFunction.listFromCloud({ org: 'my-org' }); | ||
| expect(logicFunctions).to.have.lengthOf(1); | ||
| }); | ||
|
|
||
| it('propagates errors', async () => { | ||
| nock('https://api.particle.io/v1/orgs/', ) | ||
| .intercept('/my-org/logic/functions', 'GET') | ||
| .reply(500, { error: 'Internal Server Error' } ); | ||
|
|
||
| try { | ||
| await LogicFunction.listFromCloud({ org: 'my-org' }); | ||
| } catch (error) { | ||
| expect(error.message).to.equal('HTTP error 500 from https://api.particle.io/v1/orgs/my-org/logic/functions'); | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the final object. I'll refine it once I complete the whole refactor.