Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sc 124023/add spinner #710

Merged
merged 8 commits into from
Jan 11, 2024

Conversation

hugomontero
Copy link
Contributor

@hugomontero hugomontero commented Jan 5, 2024

Description

This PR will add spinners to API calls in order to wait for the responses.

How to Test

  1. Pull down the branch: git pull && git checkout feature/sc-124023/add-spinner
  2. Install dependencies: npm i
  3. Run tests: npm run test:ci && npm run test:e2e -- --grep "Logic Function Commands"
  4. Attempt to use the different commands, check the messages and outputs:
    • Listing for sandbox
    • Listing for org
    • Creating
    • Executing for sandbox
    • Executing for org
    • Deploying new logic function
    • Deploying existing logic function
    • Disabling/enabling
    • Deleting

outcome

  • Tests should pass
  • In every command you will see spinner messages indicating an specific step that is happening (when there is an api interaction)

Related Issues / Discussions

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@hugomontero hugomontero mentioned this pull request Jan 8, 2024
6 tasks
@hugomontero hugomontero marked this pull request as ready for review January 8, 2024 15:12
@hugomontero hugomontero merged commit 68ae7e0 into feature/logic-function Jan 11, 2024
6 checks passed
@hugomontero hugomontero deleted the feature/sc-124023/add-spinner branch January 11, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants