Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Asset Verification by Checking Both Name and Hash #731

Merged
merged 1 commit into from
May 9, 2024

Conversation

keeramis
Copy link
Contributor

@keeramis keeramis commented May 8, 2024

Description

particle serial inspect looks only for the asset hash. Depending on some changes, we also would like to check the asset name.

How to Test


$ npm start -- serial inspect

> particle-cli@3.22.0 start
> node ./src/index.js serial inspect

Device: 0a10aced202194944a04af80
Platform: 35 - M SoM

Modules
  Bootloader module #0 - version 2600
  Size: 54.244 kB / MaxSize: 65.536 kB
    Integrity: PASS
    Address Range: PASS
    Platform: PASS
    Dependencies: PASS
      Bootloader module #2 - version 7

  Bootloader module #1 - version 2
  Size: 4.204 kB / MaxSize: 8.192 kB
    Integrity: PASS
    Address Range: PASS
    Platform: PASS
    Dependencies: PASS

  Bootloader module #2 - version 7
  Size: 20.312 kB / MaxSize: 303.104 kB
    Integrity: PASS
    Address Range: PASS
    Platform: PASS
    Dependencies: PASS

  System part module #1 - version 5800
  Size: 1183.62 kB / MaxSize: 1572.864 kB
    Integrity: PASS
    Address Range: PASS
    Platform: PASS
    Dependencies: PASS
      Bootloader module #0 - version 2600

  User part module #1 - version 6
  Size: 57.416 kB / MaxSize: 1572.864 kB
    UUID: a9758cd24747f45930141c5b970df1696f2096b2f3ceee01d08d29ff303b14a6
    Integrity: PASS
    Address Range: PASS
    Platform: PASS
    Dependencies: PASS
      System part module #1 - version 5800
    Asset Dependencies:
      Required:
        KG200ZAAR01A02K02P01.bin (FAIL)

Related Issues / Discussions

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@keeramis keeramis changed the title Check for asset name and hash during asset searching process Enhance Asset Verification by Checking Both Name and Hash May 8, 2024
@keeramis keeramis requested a review from monkbroc May 8, 2024 15:38
@monkbroc
Copy link
Member

monkbroc commented May 8, 2024

You can ignore E2E test failures as Hugo migrated CI to GitHub Actions in #730

@keeramis
Copy link
Contributor Author

keeramis commented May 8, 2024

This PR needs to wait until https://github.com/particle-iot/workbench/pull/245 is merged

@monkbroc
Copy link
Member

monkbroc commented May 9, 2024

There's no coupling with https://github.com/particle-iot/workbench/pull/245 so let's merge right away so it gets included when #721 is released.

@monkbroc monkbroc merged commit 2aa0897 into master May 9, 2024
4 of 6 checks passed
@monkbroc monkbroc deleted the fix/check-asset-name branch May 9, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants