-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move search parameters from POST to GET parameters #71
base: PO-267
Are you sure you want to change the base?
Conversation
…using another search form
@@ -190,12 +205,37 @@ class Search { | |||
}, 2 * 1000 ); | |||
} | |||
|
|||
getArgs( searchForm = null ) { | |||
const filter = ( searchForm || this.$filterForm || this.$searchForm ).filter( ':visible' ).serialize(); | |||
collectGuids( $el, collected = []) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tämä metodi kaipaa kommentointia. Mitä se tekee, palauttaa yms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kommentoitu.
return collected; | ||
} | ||
|
||
getArgs( $searchForm = null ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kommentointi puuttuu metodin alusta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kommentoitu.
* @param {object} data Data that was used to render the html. | ||
*/ | ||
doSearchSuccess( html, data ) { | ||
populateFilters() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metodin kommentointi...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kommentoitu.
} | ||
} | ||
|
||
openParent( i, el ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metodin kommentointi :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kommentoitu, ja poistettu i
parametri koska sitä ei käytetty.
|
||
let newUrl = location.toString().replace( new RegExp( encodeURIComponent( pof_lang.search_base ) + '\/.+', 'g' ), pof_lang.search_base + '/' + searchTerm ); | ||
handleUrlOnSearch( data ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metodin kommentointi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kommentoitu.
No description provided.