Assign error code when concatenation fails #113
Conversation
|
Feel free to give me some feedback, I am not a Kotlin person at all |
pawelduda
force-pushed
the
assign-error-code-when-concat-fails
branch
from
1170a1a
to
c07acdc
Compare
| @@ -77,8 +77,11 @@ fun ExprValue.numberValue(): Number = | |||
| fun ExprValue.timestampValue(): Timestamp = | |||
| scalar.timestampValue() ?: errNoContext("Expected timestamp: $ionValue", internal = false) | |||
|
|
|||
| fun ExprValue.stringValue(): String = | |||
| scalar.stringValue() ?: errNoContext("Expected text: $ionValue", internal = false) | |||
| fun ExprValue.stringValue(): String = scalar.stringValue() ?: | |||
There was a problem hiding this comment.
This is a general extension function that is called in multiple use cases that require to obtain a String from an ExprValue, one such case is when we need to evaluate a string append || operator.
Making this extension function report an error that always states it is due to a string append operation might lead to miscommunication.
I think the logic needs to go here where the code deals with string append. Each argument to || needs to be checked and if it is not a String value then report the more specific error message that || did not receive a value of the appropriate type (String)
There was a problem hiding this comment.
Makes sense - I'll attempt to fix it before next week.
There was a problem hiding this comment.
@therapon Can anyone take this over? A lot going on in my life, I would love to help you out but I cannot do that. Should I just trash this PR?
There was a problem hiding this comment.
Definitely don't delete it. One of us will take it over when there's time. Thanks.
There was a problem hiding this comment.
No problem, I'm glad I could contribute something meaningful.
|
#131 continuing this work |
|
#131 was pushed Thanks @pawelduda for your contribution :) |
Issue #27, if available:
Description of changes:
Solves issue #27
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.