Pass all records to the drop handler, fixes #663

partkeepr · May 14, 2016 · 6782685 · 6782685
1 parent 3c83416
commit 6782685
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 33 deletions.
diff --git a/...tKeepr/FrontendBundle/Resources/public/js/Components/CategoryEditor/CategoryEditorTree.js b/...tKeepr/FrontendBundle/Resources/public/js/Components/CategoryEditor/CategoryEditorTree.js
@@ -32,13 +32,16 @@ Ext.define("PartKeepr.CategoryEditorTree", {
     },
     onBeforeDrop: function (node, data, overModel, dropPosition, dropHandlers)
     {
-        var draggedRecord = data.records[0];
+        var draggedRecords = data.records;
         var droppedOn = this.getView().getRecord(node);
 
-        if (!(draggedRecord instanceof PartKeepr.data.HydraTreeModel)) {
-            // Workaround for EXTJS-13725 where dropping of non-tree-models cause issues
-            dropHandlers.cancelDrop();
-            this.fireEvent("foreignModelDrop", draggedRecord, droppedOn);
+        for (draggedRecord in draggedRecords) {
+            if (!(draggedRecord instanceof PartKeepr.data.HydraTreeModel)) {
+                // Workaround for EXTJS-13725 where dropping of non-tree-models cause issues
+                dropHandlers.cancelDrop();
+            }
+
+            this.fireEvent("foreignModelDrop", draggedRecords, droppedOn);
         }
     },
     onItemSelect: function (selected) {

diff --git a/src/PartKeepr/FrontendBundle/Resources/public/js/Components/Footprint/FootprintTree.js b/src/PartKeepr/FrontendBundle/Resources/public/js/Components/Footprint/FootprintTree.js
@@ -20,17 +20,19 @@ Ext.define("PartKeepr.FootprintTree", {
     },
 
     listeners: {
-        "foreignModelDrop": function (record, target)
+        "foreignModelDrop": function (records, target)
         {
-            record.setCategory(target);
-            record.save({
-                success: function ()
-                {
-                    if (record.store && record.store.reload) {
-                        record.store.reload();
+            for (var i in records) {
+                records[i].setCategory(target);
+                records[i].save({
+                    success: function ()
+                    {
+                        if (records[i].store && records[i].store.reload) {
+                            records[i].store.reload();
+                        }
                     }
-                }
-            });
+                });
+            }
         }
     }
 });
diff --git a/src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartCategoryTree.js b/src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartCategoryTree.js
@@ -30,17 +30,12 @@ Ext.define("PartKeepr.PartCategoryTree", {
         this.toolbar.add(['->', this.syncButton]);
     },
     listeners: {
-        "foreignModelDrop": function (record, target)
+        "foreignModelDrop": function (records, target)
         {
-            record.setCategory(target);
-            record.save({
-                success: function ()
-                {
-                    if (record.store && record.store.reload) {
-                        record.store.reload();
-                    }
-                }
-            });
+            for (var i in records) {
+                records[i].setCategory(target);
+                records[i].save();
+            }
         }
     }
 });
diff --git a/...eepr/FrontendBundle/Resources/public/js/Components/StorageLocation/StorageLocationTree.js b/...eepr/FrontendBundle/Resources/public/js/Components/StorageLocation/StorageLocationTree.js
@@ -19,17 +19,19 @@ Ext.define("PartKeepr.StorageLocationTree", {
         this.callParent();
     },
     listeners: {
-        "foreignModelDrop": function (record, target)
+        "foreignModelDrop": function (records, target)
         {
-            record.setCategory(target);
-            record.save({
-                success: function ()
-                {
-                    if (record.store && record.store.reload) {
-                        record.store.reload();
+            for (var i in records) {
+                records[i].setCategory(target);
+                records[i].save({
+                    success: function ()
+                    {
+                        if (records[i].store && records[i].store.reload) {
+                            records[i].store.reload();
+                        }
                     }
-                }
-            });
+                });
+            }
         }
     }
 });