Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pdf url as a part attachment freezes UI #1121

Open
G-Pereira opened this issue May 13, 2020 · 4 comments
Open

Add a pdf url as a part attachment freezes UI #1121

G-Pereira opened this issue May 13, 2020 · 4 comments

Comments

@G-Pereira
Copy link

Bug description

Adding a pdf url as a part attachment fails. Example url: https://www.ti.com/lit/ds/symlink/tps566235.pdf

Steps to reproduce

  1. Create/Edit part
  2. Add a new attachment
  3. Choose URL way and use any pdf url
  4. click OK

Expected Behaviour

Window disappears and the pdf is added to the attachment list

Current Behaviour

Nothing happens after clicking OK.

System Information

  • PartKeepr Version: 1.4.0
  • Operating System: Debian 10.4
  • Web Server: apache2
  • PHP Version: 7.1.33
  • Database and version: MariaDB 10.3.22
  • Reproducible on the demo system: Yes
@G-Pereira G-Pereira added Bug needs-triage incoming, please sort labels May 13, 2020
@christianlupus
Copy link
Collaborator

I can confirm this issue. There is a timeout issue during the post request:
Screenshot_20200514_174327

@christianlupus christianlupus added Backend Medium Priority and removed needs-triage incoming, please sort labels May 14, 2020
@christianlupus christianlupus added this to the future milestone May 14, 2020
@christianlupus
Copy link
Collaborator

I put it on medium priority because there is a simple workaround by downloading and reuploading manually.

@christianlupus
Copy link
Collaborator

I just by chance found #914. It might be related here.

@h0m3us3r
Copy link

Please merge #1165 as it solves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants