Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Needs Review' flag bug when saving #693

Closed
Addy771 opened this issue Jul 27, 2016 · 0 comments
Closed

'Needs Review' flag bug when saving #693

Addy771 opened this issue Jul 27, 2016 · 0 comments
Milestone

Comments

@Addy771
Copy link

Addy771 commented Jul 27, 2016

After ticking the "needs review" flag box on an existing part and trying to save the changes, partkeepr hangs. Trying to view a part after this does not work correctly.

Steps to reproduce:

-Open demo.partkeepr.org
-Double click 'LM394' to view it
-Tick the needs review box
-Press save

Partkeepr should hang and the save button appears grayed out. After some time the button appears normal again.

-Close the LM394 view
-Double click 'LM394' to view it

The LM394 part opens incorrectly, at the bottom of the screen. See this screenshot: https://dl.dropboxusercontent.com/u/31512672/partkeepr_flag_issue.png

I experience this on my own partkeepr install running partkeepr-0.82, as well as the demo website. I am running Google Chrome Version 51.0.2704.84 m on Windows 7

@Drachenkaetzchen Drachenkaetzchen added this to the 1.0.1 milestone Aug 2, 2016
Drachenkaetzchen pushed a commit that referenced this issue Aug 2, 2016
Return proper HTML for the flag icon, fixes #693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants