Merge pull request mozilla-l10n#380 from flodolo/issue379

Expose UTF-8 errors in JSON
pascalchevrel · Sep 25, 2015 · 91ef455 · 91ef455
2 parents 16dc6f5 + 82a0c18
commit 91ef455
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/views/export.inc.php b/views/export.inc.php
@@ -38,7 +38,13 @@
                 $export_data[$website_name][$displayed_filename]['missing'] = count($locale_analysis['Missing']);
                 $export_data[$website_name][$displayed_filename]['obsolete'] = count($locale_analysis['Obsolete']);
                 $export_data[$website_name][$displayed_filename]['translated'] = count($locale_analysis['Translated']);
-                $export_data[$website_name][$displayed_filename]['errors'] = LangManager::countErrors($locale_analysis['errors']);
+
+                $errors_number = LangManager::countErrors($locale_analysis['errors']);
+                // Also include encoding problems as an error
+                if (Utils::isUTF8($locale_filename) == false) {
+                    $errors_number++;
+                }
+                $export_data[$website_name][$displayed_filename]['errors'] = $errors_number;
             } else {
                 $file_analysis = RawManager::compareRawFiles($website, $current_locale, $filename);
                 $cmp_result = $file_analysis['cmp_result'];