Skip to content

Commit

Permalink
ci(pullapprove): Use centralised config (seek-oss#11)
Browse files Browse the repository at this point in the history
  • Loading branch information
michaeltaranto authored and pascalduez committed Nov 18, 2018
1 parent 0769cb7 commit 0d9afcf
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 12 deletions.
12 changes: 2 additions & 10 deletions .pullapprove.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
# See https://www.pullapprove.com/docs/config/extends/
version: 3

pullapprove_conditions:
- condition: "contains_regex(title, '^(build|ci|chore|docs|feat|fix|perf|refactor|revert|style|test)(\\(\\w+\\))?\\:\\s[A-Z].*$')"
unmet_status: failure
explanation: "Invalid PR title. For more information please see https://github.com/seek-oss/commitlint-config-seek"

groups:
code:
reviews:
required: 0
extends: https://raw.githubusercontent.com/seek-oss/pullapprove-config-seek/master/.pullapprove.yml
5 changes: 3 additions & 2 deletions lib/start.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,13 @@ module.exports = (config, callback) => {

const compiler = webpack(webpackConfig);
const devServer = new WebpackDevServer(compiler, webpackDevServerConfig);
const port = config.port || 9000;

devServer.listen(config.port || 9000, 'localhost', (...args) => {
devServer.listen(port, 'localhost', (...args) => {
const [err] = args;

if (!err) {
opn('http://localhost:9000');
opn(`http://localhost:${port}`);
}

if (typeof callback === 'function') {
Expand Down

0 comments on commit 0d9afcf

Please sign in to comment.