Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runs and samples per run. #351

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Update runs and samples per run. #351

merged 2 commits into from
Mar 25, 2022

Conversation

sebgrijalva
Copy link
Contributor

@sebgrijalva sebgrijalva commented Mar 24, 2022

This PR adds the option for updating runs and samples_per_run when using the Simulation.add_config() method, which has been rising recently as something users want to include.

I also added some comments for future reading.

@sebgrijalva
Copy link
Contributor Author

Not sure how to pass the docs check. Some help, @HGSilveri @lvignoli ?

@lvignoli
Copy link
Collaborator

Not sure how to pass the docs check. Some help, @HGSilveri @lvignoli ?

No idea, I also have a failing doc build on #345 with weird errors. I will push news commits there this morning, we will see if the problem remains.

@HGSilveri
Copy link
Collaborator

Not sure how to pass the docs check. Some help, @HGSilveri @lvignoli ?

It has to do with the latest update to jinja2, which has removed features being used by nbconvert (see here). A PR has been submitted on nbconvert to fix this (here), which hopefully will be accepted soon. Until then, let's just ignore it.

Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been there from the start but I guess we missed it... Thanks for the PR!

@HGSilveri HGSilveri merged commit bee6a59 into develop Mar 25, 2022
@HGSilveri HGSilveri deleted the noise-runs branch March 25, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants