This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
(PC-8025) Better user e-mail sanitization #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaty
force-pushed
the
pc-8025-user-email-sanitization
branch
from
6ca6873
to
ac550cf
Compare
dbaty
changed the title
dbaty
force-pushed
the
pc-8025-user-email-sanitization
branch
2 times, most recently
from
83640e0
to
7e4aee0
Compare
apibrac
reviewed
May 5, 2021
apibrac
reviewed
May 5, 2021
apibrac
approved these changes
May 6, 2021
xordoquy
reviewed
May 7, 2021
| # changes when this SELECT query is performed, which could raise | ||
| # an error on the UNIQUE constraint. However, I don't understand | ||
| # why we're checking the uniqueness of the email only if the user | ||
| # is new (which we do with `if user.id is None`). |
There was a problem hiding this comment.
j'imagine que c'est parce que le changement d'email n'a pas été considéré.
xordoquy
approved these changes
May 7, 2021
dbaty
force-pushed
the
pc-8025-user-email-sanitization
branch
2 times, most recently
from
e515eb1
to
bd9e613
Compare
This commit: - renames `core.users.utils.format_email()` as `sanitize_email()` for clarity; - makes sure that it is called when we store an e-mail; - makes sure that it is called when we look up an e-mail in the database. So, starting from this commit, `User.email` is stored in lowercase and e-mail lookup (including on login) is case insensitive.
dbaty
force-pushed
the
pc-8025-user-email-sanitization
branch
from
bd9e613
to
8fd94b0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
core.users.utils.format_email()assanitize_email()for clarity;So, starting from this commit,
User.emailis stored in lowercase ande-mail lookup (including on login) is case insensitive.