This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
[PC-7746] Stock.dnBookedQuantity for get_active_bookings_quantity_for_venue #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xordoquy
approved these changes
May 4, 2021
| @@ -190,6 +190,7 @@ def find_expired_bookings_ordered_by_offerer(expired_on: date = None) -> Query: | |||
|
|
|||
|
|
|||
| def get_active_bookings_quantity_for_venue(venue_id: int) -> int: | |||
| # Stock.dnBookedQuantity cannot be used here cause it's only count "not cancelled" bookings. | |||
There was a problem hiding this comment.
Suggested change
| # Stock.dnBookedQuantity cannot be used here cause it's only count "not cancelled" bookings. | |
| # Stock.dnBookedQuantity cannot be used here because we exclude used/confirmed bookings. |
rlecellier
force-pushed
the
rlecellier/sherif_dnBookingQuantity
branch
from
64465d3
to
f8d6f42
Compare
rlecellier
force-pushed
the
rlecellier/sherif_dnBookingQuantity
branch
from
f8d6f42
to
9a35a1a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property isn't usable for this function.
A comment has been added.
Also, fixing the BookingFactory to générate the right amount of
dnBookedQuantity.