Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-30377)[API] feat: add offerer address filter on get pro bookings route #12911

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

yacine-pc
Copy link
Contributor

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-30377

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques

@yacine-pc yacine-pc force-pushed the PC-30377-pro-bookings-filter-by-oa branch from ee47cce to 4a896bf Compare June 25, 2024 10:15
Copy link
Contributor

github-actions bot commented Jun 25, 2024

Visit the preview URL for this PR (updated for commit 67dabf4):

https://pc-pro-testing--pr12911-pc-30377-pro-booking-zndc3ne7.web.app

(expires Fri, 28 Jun 2024 08:27:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@yacine-pc yacine-pc force-pushed the PC-30377-pro-bookings-filter-by-oa branch 5 times, most recently from d938f57 to b9a3a29 Compare June 26, 2024 07:59
The 'offer_type' parameter was used in the previous Booking model where the same route was utilized to retrieve both individual and collective bookings.
For some time now, the route has only been used to retrieve individual bookings, so the 'offer_type' parameter is no longer used but had not yet been removed.
@yacine-pc yacine-pc force-pushed the PC-30377-pro-bookings-filter-by-oa branch from b9a3a29 to 67dabf4 Compare June 26, 2024 08:24
Copy link
Contributor

@xordoquy xordoquy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca me semble bien pour la partie back.
Est-ce qu'il ne manque pas un test quelque part sur le front ?

Copy link
Contributor

@AmineLouveau AmineLouveau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour le front

@yacine-pc yacine-pc merged commit 36288dd into master Jun 27, 2024
27 checks passed
@yacine-pc yacine-pc deleted the PC-30377-pro-bookings-filter-by-oa branch June 27, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants