Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calls to GET healthcheck/status.json are filling action_logs table #487

Closed
jouve opened this issue Jul 18, 2023 · 2 comments
Closed
Assignees

Comments

@jouve
Copy link

jouve commented Jul 18, 2023

ISSUE NAME

What you did

passbolt is deployed using the helm chart for about 1.5 months.

What happened

action_logs is growing, because of calls to GET /healthcheck/status.json from k8s healthchecks.

MariaDB [passbolt]> SELECT context, count(*) FROM action_logs GROUP BY 1 ORDER BY 2 DESC LIMIT 10;
+------------------------------+----------+
| context                      | count(*) |
+------------------------------+----------+
| GET /healthcheck/status.json |   746311 |
| GET /resources.json          |     3454 |
| GET /settings.json           |     1630 |
| GET /users.json              |     1603 |
| GET /groups.json             |     1585 |
| POST /resources.json         |     1338 |
| GET /users/me.json           |      995 |
| GET /folders.json            |      896 |
| GET /users/csrf-token.json   |      821 |
| POST /auth/login.json        |      566 |
+------------------------------+----------+

So about 96% of entries are GET /healthcheck/status.json

What you expected to happen

I guess /healthcheck/status.json could be skipped from action_logs ?

@jouve jouve changed the title calls to GET healthcheck/status.json fill table action_logs calls to GET healthcheck/status.json are filling action_logs table Jul 18, 2023
@stripthis
Copy link
Member

stripthis commented Jul 19, 2023

@jouve thanks for bringing this up, we'll add the /healthcheck/status.json to the excluded list for the logs. Ref. PB-25389

@stripthis stripthis assigned stripthis and unassigned ishanvyas22 Jul 19, 2023
@stripthis stripthis changed the title calls to GET healthcheck/status.json are filling action_logs table Fix calls to GET healthcheck/status.json are filling action_logs table Jul 19, 2023
dlen pushed a commit that referenced this issue Aug 24, 2023
PB-25389 Fix calls to GET healthcheck/status.json are filling action_logs table #487

See merge request passbolt/passbolt-pro-api!1123
@ishanvyas22
Copy link
Member

Hey @jouve, this issue has been fixed and released with v4.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants