Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenSSL 3 build issues #52

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Conversation

hoppjan
Copy link

@hoppjan hoppjan commented Sep 19, 2023

I tried to get this project to build with OpenSSL 3.0.10 (on my M1 MacBook Air).

  1. I fixed the issue in get_openssl_version as described in this note to yourself.
    However, I remain uncertain whether this resolves all scenarios or represents an optimal solution.
  2. As described by the users in Issues building openssl 3.0.0 #42, I also removed the asm(...) bits in the config/20-all-platforms.conf.
    I have no idea what that does other than fix the build issue or if it should be kept for legacy 1.1.1 builds (OpenSSL 1.1.1 went End-of-Life this month!).

After those changes I was finally able to build OpenSSL 3.0.10 for all iOS targets and it seems to work for my little use case.
I invite everyone to try the other targets (macOS, Catalyst, watchOS & tvOS) since my knowledge doesn't even cover iOS, much less all these other devices. Their parts in the config have been removed but all of this is far outside my area of expertise.
Also: OpenSSL 1.1.1w seems to build fine with all of these changes.

I hope that at least some of this can be of use in this project ^^

Closes #42

OpenSSL 1.1.1x is EOL, this should make it work for 3.x.x versions.
See https://www.openssl.org/blog/blog/2023/03/28/1.1.1-EOL/
I have absolutely no idea what this does other than fix an error I get trying to build OpenSSL 3.
@keeshux keeshux self-requested a review September 19, 2023 15:33
@keeshux
Copy link
Member

keeshux commented Sep 19, 2023

Thanks @hoppjan for your great contribution!

@keeshux keeshux self-assigned this Oct 14, 2023
@keeshux keeshux modified the milestone: OpenSSL 3 Oct 29, 2023
Copy link
Member

@keeshux keeshux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a few things here and there:

  • Drop all Bitcode leftovers
  • Use newer flag -platform_version for framework generation
  • Normalize 1.x.x version number as an exception rather than the standard
  • Default to version 3.2.0

@keeshux keeshux merged commit 12ad7b9 into passepartoutvpn:master Dec 12, 2023
@keeshux keeshux added the bug label Dec 12, 2023
@keeshux keeshux added this to the OpenSSL 3 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues building openssl 3.0.0
2 participants