Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize before migrating to UPIR #116

Merged
merged 1,501 commits into from
Feb 24, 2022
Merged

Synchronize before migrating to UPIR #116

merged 1,501 commits into from
Feb 24, 2022

Conversation

ouankou
Copy link
Contributor

@ouankou ouankou commented Feb 24, 2022

  1. Synchronize with ROSE upstream
  2. Add OpenMP SIMD transformation

ktras and others added 30 commits April 13, 2021 11:55
@ktras
Remove importModule() that was accidentally reintroduced during
95314ba 
resolution of a merge conflict
@mschordan
(codethorn) v1.12.28
361bb78 
* added type size statistics to program-stats

CODETHORN-70
@rosecompiler
(Release) Incremented version to 0.11.28.3
58e4722
@rosecompiler
Merge commit '361bb78d5ea340e114cbb45b4e8e55b36fe2c8d0' into HEAD
a822543
@rosecompiler
(Release) Incremented version to 0.11.28.4
1620af4
@matzke1
(Support) Fixed missing headers for ROSE_ABORT
7ab0799 
* ROSE_ABORT.h should include either <assert.h> or <stdlib.h>

* Some C files (xomp.c and instrumentor_lib.c) need to include
  <ROSE_ABORT.h> to avoid linking errors (C doesn't care that
  functions (or in this case a macro) is not declared).

RPM-194
@ppete
(Ada) fix Sg_File_Info warning / comments
54831a0 
- fix warnings when a file location is set and initially
  was set to compiler generated.

- add comments from source code to the AST

- add utility to convert Ada to C++ comments

- removed a spurious error message

RC-841
RC-757
@rosecompiler
(Release) Incremented version to 0.11.28.5
02db6a5
@danquinlan
(Bug) Fixed unparsing of last statement whitespace of header files.
8c7d611 
Fixed unparsing of last statement whitespace of header files (with the
token-based unparsing). The trailing whitespace of the last statement
was under some conditions being repeated (unparsed twice).

JACCEL-17
@rosecompiler
Merge commit '54831a06fc3851068d3525c8959878b8c59d2a76' into HEAD
87edf52
@rosecompiler
(Release) Incremented version to 0.11.28.6
6d6c637
@danquinlan
(Bug) Fixed unparsing of last statement whitespace of header files (n…
a49191a 
…ontokens)

Fixed unparsing of last statement whitespace of header files (with the
token-based unparsing). The trailing whitespace of the last statement
was under some conditions being repeated (unparsed twice).

JACCEL-17
@ppete
(Ada) Fixed small issues
18e1d49 
- allow empty private sections
- allow use of Standard.Ascii
- produce AdaPackageSpecDecl symbol for AdaPackageBodyDecl::get_symbol
- added convenience functions to SageInterface::ada
- quieted some debug output
- mark compilerGenerated nodes explicitely as compilerGenerated
  (instead of producing a new Sg_File_Info and hopeing everything
  was set correctly).
- added test cases and reference dot outputs

ROSE-2325
@ppete
(Ada) fixed exception handler unparsing
bf1d744 
begin and end block markers where skipped for try-blocks. This can only
be done when the try block is a function try block.
The unparser checks that (added function to SageInterfaceAda) and omits
the block markers only then, otherwise print them out.

ROSE-2325
@rosecompiler
(Release) Incremented version to 0.11.28.7
37aef55
@rosecompiler
(ROSE) Incremented version to 0.11.29.0
041e865
@mschordan
(codethorn) improved mem graph visualization with layout edges
a983ef6 
* added invisible layout nodes and edges to memory subgraph visualization
  for improved layout of clusters

CODETHORN-70
@tristanvdb
(JOV) replace_expression method for new Jov node
9c06153 
RC-839
@tristanvdb
(JOVIAL) Missing traversal for SgProcessControlStatement members
f90ead6 
RC-823
@tristanvdb
(C++11/14) ROSE header test needed the std flag
ff9715c 
RC-0000
@rosecompiler
Merge commit 'ff9715cd14e37146fd9b3b40be4c5f00aaa96185' into HEAD
aadb6ee
@chunhualiao
(PreprocessingInfo) supports PreprocessingInfo::setTypeOfDirective (D…
21b1061 
…irectiveType dt)

* add missing function to set directivey type
* used by ada2cpp to translate Ada comments into C++ style comments

RC-848
@rasmussn
(Jovial) Added testing for OVERLAY in DEF section
907e729 
RC-646
Added support for scatter (Intel SIMD)
7022fb7
@rosecompiler
(Release) Incremented version to 0.11.29.1
0dc7248
@rosecompiler
Merge commit '21b106130e908fb64c3d7db165f646a67ef8de6b' into HEAD
8968e05
@rosecompiler
(Release) Incremented version to 0.11.29.2
e8b9319
@ppete
(Ada) bug fixes
f2c762b 
- add mangling support for AdaAttributeExpr
- set scope on fake SgInitializedName nodes that represent renamed
  exceptions
  TODO: look up renamed declarations
- allow labels in package bodies
- integer parsing: allow exponents
  TODO: finish decimal type parsing
  + added test case ranges.adb
- fixed parent pointer issue with task body

ROSE-2325
@rosecompiler
Merge commit 'f2c762b3c30100b7b0975b34adfe65beb805b0dd' into HEAD
cf2e5dc
@rosecompiler
(Release) Incremented version to 0.11.29.3
197be78
XinyaoYI and others added 25 commits June 29, 2021 17:34
@XinyaoYI @ouankou
Added TARGET UPDATE directive and some of its clauses.
2990111 
if clause, nowait clause, device clause and depend clause
@ouankou
Fix compilation warnings and update ompparser submodule
cff4fba
@ouankou
Update ompparser submobule
169fafd
@XinyaoYI @ouankou
Added the REQUIRES directive
5445a16
@XinyaoYI @ouankou
Added the requires directive, there is an error when using the automa…
8cdf09c 
…ted test infrastructure. Need to fix it.
@XinyaoYI @ouankou
Fixed the errors in Requires directive and added the tests.
7c80253
@XinyaoYI @ouankou
Added atomic_default_mem_order clause for REQUIRES directive
1ccd8d2
@XinyaoYI @ouankou
Added the ext_implementation-defined-requirement clause for REQUIRES …
4b9da29 
…directive
@XinyaoYI @ouankou
Fixed the error in DECLARE SIMD directive and added the test
805abe1
@XinyaoYI @ouankou
Added 4 combined directives and there tests.
9ca4139 
Distribute simd, Distribute parallel for, Distribute parallel for simd, Taskloop simd
@XinyaoYI @ouankou
Added affinity clause
acd4e57
@XinyaoYI @ouankou
Added the test for affinity clause
0ae2a1b
@XinyaoYI @ouankou
Clean some useless comments
6c4ad4e
@ouankou
Update CMake configuration to enable OpenMP tests
a64fa0d
@ouankou
Restore the CUDA language support
dbc34dd 
In commit 2073f14,
we removed the pre-included CUDA headers.
However, they are required to support CUDA source code. It's necessary to copy the file "preinclude-cuda.h" and specify the path to CUDA headers in the system.

Since the CUDA 7.5 header package in REX was removed, to build REX compiler with CUDA support, we need to run:
./configure --prefix=$REX_ROOT/rex_install --with-boost=/usr --with-boost-libdir=$BOOST_LIB --enable-languages=c,c++,cuda,fortran --with-cuda-inc=/opt/cuda/include --disable-tests-directory --disable-tutorial-directory

"--with-cuda-inc=<path-to-CUDA-headers>" should be modified based on the actual CUDA toolkit installation.
@ouankou
Fix omp lowering
f13670d 
Last synchronization with ROSE brought a change in the file "src/frontend/SageIII/sageInterface/sageBuilder.C".

When creating a new source file for the outlined function, it was attaching some necessary preprocessing info to the new file.
In the latest commits from ROSE, during outlining, it calls a secondary pass to duplicate the original source file, which contains all the OpenMP source code, and then repeat the whole processing from scratch again. This secondary pass will parse the source code, create the AST and lower the AST.
The lowering will trigger the secondary pass again. Therefore, it falls to an infinite loop here.

As a temporary fix to issue #104, we reverted this particular change for now. More details should be investigated later.
@ouankou
Add the omp transformation for TARGET TEAMS DISTRIBUTE PARALLEL FOR d…
4ac137d 
…irective
@ouankou
(Hopefully) Fix jacobi test
260c749
@ouankou
Fixes to Arm SVE for reduction
00f2acf
@ouankou
Added ARM gather generation; fixes to Arm scalar store
98184bf
@ouankou
Made fix to partial store to eliminate extra instructions
1c72ef6
@ouankou
Fixed issue caused introduced by reduction fix
1006b50
@ouankou
Made fixes to Arm generator, mainly for reductions
e88a49e
@XinyaoYI @ouankou
Update .gitmodules
55b4aa3
@ouankou
Added Arm SVE-specific update for addition reductions
045c226
@ouankou ouankou merged commit 9819932 into main Feb 24, 2022
@ouankou ouankou deleted the dev branch February 24, 2022 14:04
@yanyh15
Copy link
Member

yanyh15 commented Feb 24, 2022 via email

@ouankou
Copy link
Contributor Author

ouankou commented Feb 24, 2022

Hi Anjia, Not sure how you synchronize with ROSE official. From my past experience, it often required cherry-picking some commits since straight git merge or rebase will pull in many changes that we already deleted, e.g. those code for php, java, etc. Let me know how you did the sync. Yonghong

Dr. Yan, sorry for the confusion. It is a short summary of the difference between our main and development branches. The "sync" here refers to the synchronization with ROSE you did last year. After that, I only cherry-picked one or two commits from ROSE to fix bugs.

@yanyh15
Copy link
Member

yanyh15 commented Feb 24, 2022 via email

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.