Project restructure #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
variables in more nested scope - Linting: Remove jshint - Linting: Apply overrides to add mocha-specific config - Linting: Add recommended fields to `package.json` - Linting: Remove unused disable directives - Git/npm/Linting: ignore `var` - Fix: Point to correct path in Makefile `view-cov`
`authenticate.js` middleware when switching to strict mode with errors
upon setting a property on a boolean )
- npm: No need for full path within package.json scripts
- remark lint default preferred styling
…e require-jsdoc for tests; use new preference for "object" over "Object" - npm: Update devDeps
* Merged in https://github.com/passport-next/skel * Updated project according to template * Lint fixes
Pull Request Test Coverage Report for Build 96
💛 - Coveralls |
rwky
force-pushed
the
project-restructure
branch
from
1ea643e
to
5d1a719
Compare
|
@brettz9 can you check this over and let me know if it looks ok? Any other @passport-next/developers want to chime in feel free! |
|
This is exciting! Glad to see such a forward-looking approach... Have got a cold now, but intend to add some comments/questions... |
brettz9
reviewed
Jun 16, 2019
brettz9
reviewed
Jun 16, 2019
brettz9
reviewed
Jun 16, 2019
brettz9
reviewed
Jun 16, 2019
brettz9
reviewed
Jun 16, 2019
brettz9
reviewed
Jun 16, 2019
brettz9
reviewed
Jun 16, 2019
brettz9
requested changes
Jun 16, 2019
|
👍 thanks for looking at that lot, I'll make some tweaks in a bit! Hope you feel better soon. |
* Removed comma-dangle config since it's included in the config * Updated .npmignore and .gitignore * Removed licenses in favour of licence from package.json * Cleaned up lint commands * Removed deprecated test-cov and view-cov commands (TODO replace these)
|
@brettz9 ok check out out now |
brettz9
reviewed
Jun 19, 2019
brettz9
reviewed
Jun 19, 2019
brettz9
reviewed
Jun 19, 2019
|
OK fixed those typos, @brettz9 check again! |
|
All looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes all lint fixes from @brettz9 and some restructuring so all passport-next projects and work from the same base project.
I've made https://github.com/passport-next/skel which acts as a skeleton template for all passport-next projects this is the first one to use it, this means if we want to say change a github template we do it in one repo and simply pull from that repo instead of having to edit each file individually on each repo, it supports jinja2 templates to make the files such as README.md etc
The eslint config has been forked from https://github.com/brettz9/eslint-config-ash-nazg to https://github.com/passport-next/eslint-config-passport-next it's almost identical at the moment, this just means that our config is under the org and we can pull in @brettz9 changes when we want.
Checklist
$ make test) executes successfully.$ npm run-script lint) executes successfully.