Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #2731

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/CardList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const CardList = ({ className, isLoading = false, initialOpen = true }: C
);

useEffect(() => {
// update all verfied states
// update all verified states
setSelectedProviders(
PLATFORMS.reduce((platforms, platform) => {
// get all providerIds for this platform
Expand Down
2 changes: 1 addition & 1 deletion iam/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ There are a few options for adding the variable into the build process:
- Add the value to AWS Secrets Manager, and add a new item to the `secrets` array in the `iam` container definition.
**Note that you will have to add it to all AWS Secrets Manager resources in all AWS accounts used.**
- Add the value to Github Actions Secrets and inject it into the process environment IAM-related workflows on the Pulumi
deploy step. Pull the variable into the Pulumi files using `proccess.env.NEW_VAR`, and refer to
deploy step. Pull the variable into the Pulumi files using `process.env.NEW_VAR`, and refer to
that variable in the `secrets` array.
- (If the value can be public) Hardcode the value in plaintext into the Github Actions script and feed it into the
Pulumi file as described above. Alternatively, hardcode the value into the Pulumi file directly. Also note that it can
Expand Down
2 changes: 1 addition & 1 deletion iam/src/utils/challenge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { verifyDidChallenge } from "./verifyDidChallenge.js";
import { utils } from "ethers";
// request a challenge sig
export const getChallenge = (payload: RequestPayload): ChallengePayload => {
// @TODO - expand this to allow providers to set custom challanges?
// @TODO - expand this to allow providers to set custom challenges?
const getChallengeString = (provider: string, nonce: string): string => {
switch (provider) {
case "SignerChallenge":
Expand Down