Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AuthenticatorSelection extension #435

Merged
merged 1 commit into from Oct 23, 2023

Conversation

joegoldman2
Copy link
Contributor

Contributes to #426

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (15263ca) 77.50% compared to head (e30cafc) 77.52%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   77.50%   77.52%   +0.02%     
==========================================
  Files          98       98              
  Lines        2716     2714       -2     
  Branches      445      445              
==========================================
- Hits         2105     2104       -1     
+ Misses        492      491       -1     
  Partials      119      119              
Files Coverage Δ
...ls/Objects/AuthenticationExtensionsClientInputs.cs 14.28% <ø> (+1.78%) ⬆️
...s/Objects/AuthenticationExtensionsClientOutputs.cs 85.71% <ø> (-1.79%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Regenhardt Regenhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-extension AuthenticatorSelection is already under test so this looks good to me.

@aseigler aseigler self-requested a review October 23, 2023 14:15
@aseigler
Copy link
Collaborator

Good cleanup!

@aseigler aseigler merged commit 24e2626 into passwordless-lib:master Oct 23, 2023
7 checks passed
@joegoldman2 joegoldman2 deleted the contribute/426 branch October 23, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants