Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AuthenticatorSelection extension #435

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Remove AuthenticatorSelection extension #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions Src/Fido2.Models/Objects/AuthenticationExtensionsClientInputs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@ public sealed class AuthenticationExtensionsClientInputs
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
public string AppID { get; set; }

/// <summary>
/// This extension allows a WebAuthn Relying Party to guide the selection of the authenticator that will be leveraged when creating the credential. It is intended primarily for Relying Parties that wish to tightly control the experience around credential creation.
/// https://www.w3.org/TR/webauthn/#sctn-authenticator-selection-extension
/// </summary>
[JsonPropertyName("authnSel")]
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
public byte[][] AuthenticatorSelection { get; set; }

/// <summary>
/// This extension enables the WebAuthn Relying Party to determine which extensions the authenticator supports.
/// https://www.w3.org/TR/webauthn/#sctn-supported-extensions-extension
Expand Down
7 changes: 0 additions & 7 deletions Src/Fido2.Models/Objects/AuthenticationExtensionsClientOutputs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@ public class AuthenticationExtensionsClientOutputs
[JsonPropertyName("appid")]
public bool AppID { get; set; }

/// <summary>
/// This extension allows a WebAuthn Relying Party to guide the selection of the authenticator that will be leveraged when creating the credential. It is intended primarily for Relying Parties that wish to tightly control the experience around credential creation.
/// https://www.w3.org/TR/webauthn/#sctn-authenticator-selection-extension
/// </summary>
[JsonPropertyName("authnSel")]
public bool AuthenticatorSelection { get; set; }

/// <summary>
/// This extension enables the WebAuthn Relying Party to determine which extensions the authenticator supports.
/// https://www.w3.org/TR/webauthn/#sctn-supported-extensions-extension
Expand Down
21 changes: 0 additions & 21 deletions Test/AuthenticatorResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@ public void TestAuthenticatorAttestationRawResponse()
Extensions = new AuthenticationExtensionsClientOutputs
{
AppID = true,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand All @@ -283,7 +282,6 @@ public void TestAuthenticatorAttestationRawResponse()
Assert.Equal(new byte[] { 0xa0 }, rawResponse.Response.AttestationObject);
Assert.Equal(clientDataJson, rawResponse.Response.ClientDataJson);
Assert.True(rawResponse.Extensions.AppID);
Assert.True(rawResponse.Extensions.AuthenticatorSelection);
Assert.Equal(new string[] { "foo", "bar" }, rawResponse.Extensions.Extensions);
Assert.Equal("test", rawResponse.Extensions.Example);
Assert.Equal((ulong)4, rawResponse.Extensions.UserVerificationMethod[0][0]);
Expand Down Expand Up @@ -1239,7 +1237,6 @@ public void TestAuthenticatorAssertionRawResponse()
Extensions = new AuthenticationExtensionsClientOutputs
{
AppID = true,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -1268,7 +1265,6 @@ public void TestAuthenticatorAssertionRawResponse()
Assert.Equal(clientDataJson, assertionResponse.Response.ClientDataJson);
Assert.Equal(new byte[] { 0xf1, 0xd0 }, assertionResponse.Response.UserHandle);
Assert.True(assertionResponse.Extensions.AppID);
Assert.True(assertionResponse.Extensions.AuthenticatorSelection);
Assert.Equal(new string[] { "foo", "bar" }, assertionResponse.Extensions.Extensions);
Assert.Equal("test", assertionResponse.Extensions.Example);
Assert.Equal((ulong)4, assertionResponse.Extensions.UserVerificationMethod[0][0]);
Expand Down Expand Up @@ -1317,7 +1313,6 @@ public void TestAuthenticatorAssertionTypeNotPublicKey()
Extensions = new AuthenticationExtensionsClientOutputs
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -1386,7 +1381,6 @@ public void TestAuthenticatorAssertionIdMissing()
Extensions = new AuthenticationExtensionsClientOutputs
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -1456,7 +1450,6 @@ public void TestAuthenticatorAssertionRawIdMissing()
Extensions = new AuthenticationExtensionsClientOutputs()
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -1526,7 +1519,6 @@ public void TestAuthenticatorAssertionUserHandleEmpty()
Extensions = new AuthenticationExtensionsClientOutputs()
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -1596,7 +1588,6 @@ public void TestAuthenticatorAssertionUserHandleNotOwnerOfPublicKey()
Extensions = new AuthenticationExtensionsClientOutputs()
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -1666,7 +1657,6 @@ public void TestAuthenticatorAssertionTypeNotWebAuthnGet()
Extensions = new AuthenticationExtensionsClientOutputs
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -1738,7 +1728,6 @@ public void TestAuthenticatorAssertionAppId()
Extensions = new AuthenticationExtensionsClientOutputs()
{
AppID = true,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -1809,7 +1798,6 @@ public void TestAuthenticatorAssertionInvalidRpIdHash()
Extensions = new AuthenticationExtensionsClientOutputs()
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -1881,7 +1869,6 @@ public void TestAuthenticatorAssertionUPRequirementNotMet()
Extensions = new AuthenticationExtensionsClientOutputs
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -1952,7 +1939,6 @@ public void TestAuthenticatorAssertionUVPolicyNotMet()
Extensions = new AuthenticationExtensionsClientOutputs
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -2021,7 +2007,6 @@ public void TestAuthenticatorAssertionBEPolicyRequired()
Extensions = new AuthenticationExtensionsClientOutputs()
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -2091,7 +2076,6 @@ public void TestAuthenticatorAssertionBEPolicyDisallow()
Extensions = new AuthenticationExtensionsClientOutputs
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -2161,7 +2145,6 @@ public void TestAuthenticatorAssertionBSPolicyRequired()
Extensions = new AuthenticationExtensionsClientOutputs
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -2231,7 +2214,6 @@ public void TestAuthenticatorAssertionBSPolicyDisallow()
Extensions = new AuthenticationExtensionsClientOutputs
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -2302,7 +2284,6 @@ public void TestAuthenticatorAssertionStoredPublicKeyMissing()
Extensions = new AuthenticationExtensionsClientOutputs()
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -2372,7 +2353,6 @@ public void TestAuthenticatorAssertionInvalidSignature()
Extensions = new AuthenticationExtensionsClientOutputs()
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down Expand Up @@ -2449,7 +2429,6 @@ public void TestAuthenticatorAssertionSignCountSignature()
Extensions = new AuthenticationExtensionsClientOutputs()
{
AppID = false,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down
1 change: 0 additions & 1 deletion Test/Fido2Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ public async Task<Fido2.CredentialMakeResult> MakeAttestationResponseAsync()
Extensions = new AuthenticationExtensionsClientOutputs()
{
AppID = true,
AuthenticatorSelection = true,
Extensions = new string[] { "foo", "bar" },
Example = "test",
UserVerificationMethod = new ulong[][]
Expand Down