fix #508

[dbrakenhoff]

Short Description

parse a single dict as settings correctly in wellmodel

Checklist before PR can be merged:

• closes issue [BUG] settings dictionary not parsed correctly for WellModel #508
• Format code with Black formatting

[codacy-production]

Coverage summary from Codacy

Merging #514 (79563fe) into dev (0a906fd) - See PR on Codacy

Coverage variation	Diff coverage
✅ +8.49% (target: +0.00%)	100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (0a906fd)	4875	3483	71.45%
Head commit (79563fe)	4875 (+0)	3897 (+414)	79.94% (+8.49%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#514)	1	1	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

[raoulcollenteur]

Should I review this?

[dbrakenhoff]

Yes

[raoulcollenteur]

@dbrakenhoff is this supposed to be a 0.23.1 bug fix release? If so, the merge should go directly into master. Because Dev is already on 1.0b with many changes.

EDIT: or make a new branch for 0.23.1 and merge that one into master later. But 0.23.1 should not include the chances currently on dev.

[dbrakenhoff]

You're right, this should be a change for 0.23.1. I'll make a new branch and submit a new PR into master.