Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #577 improve validate_series #578

Merged
merged 16 commits into from
May 11, 2023
Merged

Conversation

dbrakenhoff
Copy link
Member

  • add multi-column dataframe error+message
  • add series.index NaT error and solution in msg

Short Description

See #577

Checklist before PR can be merged:

- add multi-column dataframe error+message
- add series.index NaT error and solution in msg
@dbrakenhoff dbrakenhoff self-assigned this Mar 22, 2023
@dbrakenhoff dbrakenhoff added the enhancement Indicates improvement of existing features label Mar 22, 2023
@dbrakenhoff dbrakenhoff linked an issue Mar 22, 2023 that may be closed by this pull request
@codacy-production
Copy link

codacy-production bot commented Mar 22, 2023

Coverage summary from Codacy

Merging #578 (a878821) into dev (1938128) - See PR on Codacy

Coverage variation Diff coverage
-0.14% (target: +0.00%) 30.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1938128) 4941 3596 72.78%
Head commit (a878821) 4949 (+8) 3595 (-1) 72.64% (-0.14%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#578) 10 3 30.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@martinvonk martinvonk force-pushed the 577-improve-validate_series branch from 2f033d5 to 62358f0 Compare May 4, 2023 09:23
@martinvonk
Copy link
Collaborator

yikes... readthedocs fails because:

Collecting future (from uncertainties>=3.1.4->lmfit>=1.0.0->pastas==1.0.1)
  Downloading future-0.18.3.tar.gz (840 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 840.9/840.9 kB 289.5 MB/s eta 0:00:00
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'error'
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      ERROR: Can not execute `setup.py` since setuptools is not available in the build environment.
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

@raoulcollenteur
Copy link
Member

Yeah the future sucks :p Are you working on a solution or should I look into it?

@martinvonk
Copy link
Collaborator

martinvonk commented May 4, 2023

I don't now if we can do much about this? The error occurs while installing lmfit's dependencies.

update docstring
replace append by concat: 'Series' object has no attribute 'append'
@dbrakenhoff dbrakenhoff merged commit b5ccbd5 into dev May 11, 2023
9 of 10 checks passed
@dbrakenhoff dbrakenhoff deleted the 577-improve-validate_series branch May 11, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates improvement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] improve validate_series checks and messages
3 participants