-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update testing routine with fixtures and benchmark notebooks test #583
Conversation
also accepts a list of StressModel
fixtures are now autodetected by pytest according to: https://docs.pytest.org/en/6.2.x/fixture.html
Coverage summary from CodacyMerging #583 (5c74d9c) into
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
axes should be -2 instead of -1
Maybe we can merge this @dbrakenhoff ? |
The blocked check is preventing me from merging. I've removed the test suite for Jupyter Notebooks from required status checks. It allows me to merge this PR, but we need to check if we need to re-add that status check. |
Short Description
Move pytest fixture to conftest.py
Fixutres are autodetected by pytest in conftest.py and don't have to be imported anymore.
For more info: https://docs.pytest.org/en/6.2.x/fixture.html
Test benchmark notebooks on pull request to master branch
Fixes point 3 of [ENHANCEMENT] Update (unit) testing and GitHub continuous integration with tox #509