Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing routine with fixtures and benchmark notebooks test #583

Merged
merged 6 commits into from
Apr 12, 2023

Conversation

martinvonk
Copy link
Collaborator

@martinvonk martinvonk commented Mar 29, 2023

Short Description

  1. Move pytest fixture to conftest.py
    Fixutres are autodetected by pytest in conftest.py and don't have to be imported anymore.
    For more info: https://docs.pytest.org/en/6.2.x/fixture.html

  2. Test benchmark notebooks on pull request to master branch
    Fixes point 3 of [ENHANCEMENT] Update (unit) testing and GitHub continuous integration with tox #509

also accepts a list of StressModel
fixtures are now autodetected by pytest according to:
https://docs.pytest.org/en/6.2.x/fixture.html
@martinvonk martinvonk changed the title Fixtures Update testing routine by moving pytest fixtures to conftest.py Mar 29, 2023
@martinvonk martinvonk marked this pull request as ready for review March 29, 2023 08:27
@codacy-production
Copy link

codacy-production bot commented Mar 29, 2023

Coverage summary from Codacy

Merging #583 (5c74d9c) into dev (7a9e44c) - See PR on Codacy

Coverage variation Diff coverage
+0.00% (target: +0.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7a9e44c) 4914 3569 72.63%
Head commit (5c74d9c) 4914 (+0) 3569 (+0) 72.63% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#583) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@martinvonk martinvonk added the code quality Related to code quality, testing, CI, project setup etc. label Mar 29, 2023
@martinvonk martinvonk changed the title Update testing routine by moving pytest fixtures to conftest.py Update testing routine with fixtures and benchmark notebooks test Mar 29, 2023
axes should be -2 instead of -1
@martinvonk
Copy link
Collaborator Author

Maybe we can merge this @dbrakenhoff ?

@dbrakenhoff
Copy link
Member

The blocked check is preventing me from merging. I've removed the test suite for Jupyter Notebooks from required status checks.

It allows me to merge this PR, but we need to check if we need to re-add that status check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Related to code quality, testing, CI, project setup etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Update (unit) testing and GitHub continuous integration with tox
2 participants