-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if precipitation is probably in mm/d #618
Check if precipitation is probably in mm/d #618
Conversation
Coverage summary from CodacyMerging #618 (5a5c6f6) into
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos and suggestions for slightly clearer documentation/messages.
Otherwise good to go!
Thanks for the quick review, just made the changes and I will merge after all checks are passed :) |
Short Description
Simple but I think powerful check to see if precipitation may be provided in m/d instead of mm/d for the nonlinear recharge models, which is a common mistake causing issues. Also improved docs on this.
Checklist before PR can be merged: