Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if precipitation is probably in mm/d #618

Conversation

raoulcollenteur
Copy link
Member

@raoulcollenteur raoulcollenteur commented Aug 17, 2023

Short Description

Simple but I think powerful check to see if precipitation may be provided in m/d instead of mm/d for the nonlinear recharge models, which is a common mistake causing issues. Also improved docs on this.

Checklist before PR can be merged:

@raoulcollenteur raoulcollenteur self-assigned this Aug 17, 2023
@raoulcollenteur raoulcollenteur added the enhancement Indicates improvement of existing features label Aug 17, 2023
@raoulcollenteur raoulcollenteur added this to the 1.2 milestone Aug 17, 2023
@raoulcollenteur raoulcollenteur linked an issue Aug 17, 2023 that may be closed by this pull request
@codacy-production
Copy link

codacy-production bot commented Aug 17, 2023

Coverage summary from Codacy

Merging #618 (5a5c6f6) into dev (aee5246) - See PR on Codacy

Coverage variation Diff coverage
-0.02% (target: +0.00%) 33.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aee5246) 5135 3717 72.39%
Head commit (5a5c6f6) 5138 (+3) 3718 (+1) 72.36% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#618) 3 1 33.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@raoulcollenteur raoulcollenteur mentioned this pull request Aug 17, 2023
6 tasks
pastas/stressmodels.py Outdated Show resolved Hide resolved
pastas/stressmodels.py Outdated Show resolved Hide resolved
pastas/stressmodels.py Outdated Show resolved Hide resolved
Copy link
Member

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos and suggestions for slightly clearer documentation/messages.

Otherwise good to go!

@raoulcollenteur
Copy link
Member Author

Thanks for the quick review, just made the changes and I will merge after all checks are passed :)

@raoulcollenteur raoulcollenteur merged commit 1906713 into dev Aug 17, 2023
9 of 10 checks passed
@raoulcollenteur raoulcollenteur deleted the 609-enhancement-throw-warning-if-recharge-flux-looks-like-md branch August 17, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates improvement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Throw warning if recharge flux looks like m/d
2 participants