Update Master to Pastas 1.2 #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- improve simulation has NaNs msg to include example code for stressmodel settings - add traps for method is None in fill_before and fill_after, raise ValueError - avoid issues with trailing or leading NaNs in time series by setting tmin/tmax to first/last valid index - add more informative error message when weights and observations are not same length - improve msg formatting
no longer needed since Numba v0.57
Because the metrics can also be used directly without Pastas as well :-)
Coverage summary from CodacyMerging #619 (1906713) into
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
dbrakenhoff
reviewed
Aug 17, 2023
dbrakenhoff
reviewed
Aug 17, 2023
dbrakenhoff
reviewed
Aug 17, 2023
dbrakenhoff
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Update the master branch to Pastas 1.2. Should good to go after merging #618 into dev.
Checklist before PR can be merged: