-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Pandas 2.2 (FutureWarning) issues #684
Conversation
ValueError: duplicate time-indexes were found in the time series GWL. Make sure there are no duplicate indices. For example by `grouped = series.groupby(level=0); series = grouped.mean()`or `series = series.loc[~series.index.duplicated(keep='first/last')]`
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
You want to merge this @raoulcollenteur before #686? I was not able to fix the FutureWarnings yet. That takes more time. But I did fix the failing test with Pandas. But if we merge this now, we can support more pandas versions in Pastas v1.4.. |
I added all FutureWarnings I found to #72. I have a feeling most things will be deprecated for Pandas 3.0 so we could add Pandas < 3.0 in the dependencies list. |
Pandas 3.0 milestone is set for 1st of April: https://github.com/pandas-dev/pandas/milestone/102 |
Can only be done for Pandas >=2.2
@martinvonk perhaps you can have a quick look at this? I also opened a new issue for Pandas 3.0 #687 to track changes necessary that only work with pandas > 2.1. |
something small
see #686 why
Short Description
This PR solves many of the future warning for Pandas 2.2 in advance to 3.0.
Related to issue #629