Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master to Pastas 1.4 #686

Merged
merged 12 commits into from
Feb 19, 2024
Merged

Update master to Pastas 1.4 #686

merged 12 commits into from
Feb 19, 2024

Conversation

raoulcollenteur
Copy link
Member

@raoulcollenteur raoulcollenteur commented Feb 16, 2024

Short Description

This PR updates the master branch to Pastas 1.4. Many small updates and added python 3.12 support. Signatures module received a big update. Pastas is now compatible with Pandas 2.2 as well.

Checklist before PR can be merged:

  • is documented
  • Format code with Black formatting
  • type hints for functions and methods
  • tests added / passed
  • Example Notebook (for new features)
  • Remove output for all notebooks with changes

@raoulcollenteur raoulcollenteur self-assigned this Feb 16, 2024
@raoulcollenteur raoulcollenteur added this to the 1.4 milestone Feb 16, 2024
Copy link

codacy-production bot commented Feb 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: +0.00%) 78.51%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (dbe3275) 5853 4376 74.77%
Head commit (3189a40) 5999 (+146) 4484 (+108) 74.75% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#686) 349 274 78.51%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@martinvonk
Copy link
Collaborator

martinvonk commented Feb 16, 2024

I see that the test_notebooks.py is tested by the py38-py312 test suites while this is not intended. Only the Test suite for all unit tests including Notebooks should do this. It worked in the past; with the @pytst.mark.notebooks decorator..

We could try changing in the pyproject.toml:

from:

[testenv]
description = run unit tests
extras = ci
commands =
        pytest tests -m "not notebooks" -m "not bnotebooks"

to:

commands =
        pytest tests -m "not notebooks and not bnotebooks"

Maybe you can try this @raoulcollenteur. I can't commit to the dev branch.

martinvonk added a commit that referenced this pull request Feb 19, 2024
Co-authored-by: Raoul Collenteur <raoulcollenteur@gmail.com>
pastas/version.py Outdated Show resolved Hide resolved
@martinvonk
Copy link
Collaborator

I also get this warning:

This branch is out-of-date with the base branch
Merge the latest changes from master into this branch.

@raoulcollenteur raoulcollenteur removed the request for review from dbrakenhoff February 19, 2024 12:53
@raoulcollenteur
Copy link
Member Author

Will merge the PR after all the checks have passed and release Pastas 1.4!

Thanks for all the work from everyone!

Cheers,
Raoul

Copy link
Member

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@raoulcollenteur raoulcollenteur merged commit eabc767 into master Feb 19, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants