-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update master to Pastas 1.4 #686
Conversation
Co-authored-by: MatevzVremec <matevz.vremec@gmail.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
I see that the test_notebooks.py is tested by the py38-py312 test suites while this is not intended. Only the Test suite for all unit tests including Notebooks should do this. It worked in the past; with the We could try changing in the pyproject.toml: from:
to:
Maybe you can try this @raoulcollenteur. I can't commit to the dev branch. |
Co-authored-by: Raoul Collenteur <raoulcollenteur@gmail.com>
I also get this warning:
|
Will merge the PR after all the checks have passed and release Pastas 1.4! Thanks for all the work from everyone! Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Short Description
This PR updates the master branch to Pastas 1.4. Many small updates and added python 3.12 support. Signatures module received a big update. Pastas is now compatible with Pandas 2.2 as well.
Checklist before PR can be merged: