Data Join can occur off device #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The group just discussed this aspect of the design dimension and there was no objection (philosophically) to the idea of source and trigger events being joined (attribution being performed) server side.
martinthomson
approved these changes
Jun 16, 2023
|
|
||
| ## Location of Data Join | ||
|
|
||
| The community group has reached general agreement that data join could potentially occur off device within a some type of server side architecture that achieves our desired security goals. |
There was a problem hiding this comment.
Suggested change
| The community group has reached general agreement that data join could potentially occur off device within a some type of server side architecture that achieves our desired security goals. | |
| The community group has reached general agreement that data join could potentially occur off device within a some type of server-side architecture that achieves our desired security goals. |
...I couldn't resist.
There was a problem hiding this comment.
Suggested change
| The community group has reached general agreement that data join could potentially occur off device within a some type of server side architecture that achieves our desired security goals. | |
| The community group has reached general agreement that data join could potentially occur off device within some type of server-side architecture that achieves our desired security goals. |
One more nit on this line.
There was a problem hiding this comment.
I might phrase this slightly differently though.
Suggested change
| The community group has reached general agreement that data join could potentially occur off device within a some type of server side architecture that achieves our desired security goals. | |
| The community group has reached general agreement that data join could potentially occur off device within a some type of server-side architecture. | |
| This is conditional on having adequate protections for any data that leaves a device, in line with our security and privacy goals. |
|
High level, did you consider moving this as a subsection under the "Server Architecture may exist" header? It seems somewhat natural for that to describe a section of what server architectures are acceptable. |
|
Makes sense - happy for this to be under that section |
|
I don't know how to edit commits made through the Github UI, so I just made a new one with ya'lls proposed changes =). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group just discussed this aspect of the design dimension and there was no objection (philosophically) to the idea of source and trigger events being joined (attribution being performed) server side.